On Wed, 28 Dec 2016 11:17:00 -0800 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Dec 27, 2016 at 7:53 PM, Nicholas Piggin <npiggin@xxxxxxxxx> wrote: > >> > >> Yeah, that patch is disgusting, and doesn't even help x86. > > > > No, although it would help some cases (but granted the bitops tend to > > be problematic in this regard). To be clear I'm not asking to merge it, > > just wondered your opinion. (We need something more for unlock_page > > anyway because the memory barrier in the way). > > The thing is, the patch seems pointless anyway. The "add_return()" > kind of cases already return the value, so any code that cares can > just use that. And the other cases are downright incorrect, like the > removal of "volatile" from the bit test ops. Yeah that's true, but you can't carry that over multiple multiple primitives. For bitops it's often the case you get several bitops on the same word close together. > > >> It also > >> depends on the compiler doing the right thing in ways that are not > >> obviously true. > > > > Can you elaborate on this? GCC will do the optimization (modulo a > > regression https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77647) > > So the removal of volatile is just one example of that. You're > basically forcing magical side effects. I've never seen this trick > _documented_, and quite frankly, the gcc people have had a history of > changing their own documentation when it came to their own extensions > (ie they've changed how inline functions work etc). > > But I also worry about interactions with different gcc versions, or > with the LLVM people who try to build the kernel with non-gcc > compilers. > > Finally, it fundamentally can't work on x86 anyway, except for the > add-return type of operations, which by definitions are pointless (see > above). > > So everything just screams "this is a horrible approach" to me. You're probably right. The few cases where it matters may just be served with special primitives. > > > Patch seems okay, but it's kind of a horrible primitive. What if you > > did clear_bit_unlock_and_test_bit, which does a __builtin_constant_p > > test on the bit numbers and if they are < 7 and == 7, then do the > > fastpath? > > So the problem with that is that it makes no sense *except* in the > case where the bit is 7. So why add a "generic" function for something > that really isn't generic? Yeah you're also right, I kind of realized after hitting send. > > I agree that it's a hacky interface, but I also happen to believe that > being explicit about what you are actually doing causes less pain. > It's not magical, and it's not subtle. There's no question about what > it does behind your back, and people won't use it by mistake in the > wrong context where it doesn't actually work any better than just > doing the obvious thing. Okay. The name could be a bit better though I think, for readability. Just a BUILD_BUG_ON if it is not constant and correct bit numbers? BTW. I just notice in your patch too that you didn't use "nr" in the generic version. Thanks, Nick -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>