On Thu, 22 Dec 2016, Michal Hocko wrote:
> > Currently, when defrag is set to "madvise", thp allocations will direct
> > reclaim. However, when defrag is set to "defer", all thp allocations do
> > not attempt reclaim regardless of MADV_HUGEPAGE.
> >
> > This patch always directly reclaims for MADV_HUGEPAGE regions when defrag
> > is not set to "never." The idea is that MADV_HUGEPAGE regions really
> > want to be backed by hugepages and are willing to endure the latency at
> > fault as it was the default behavior prior to commit 444eb2a449ef ("mm:
> > thp: set THP defrag by default to madvise and add a stall-free defrag
> > option").
>
> AFAIR "defer" is implemented exactly as intended. To offer a never-stall
> but allow to form THP in the background option. The patch description
> doesn't explain why this is not good anymore. Could you give us more
> details about the motivation and why "madvise" doesn't work for
> you? This is a user visible change so the reason should better be really
> documented and strong.
>
The offering of defer breaks backwards compatibility with previous
settings of defrag=madvise, where we could set madvise(MADV_HUGEPAGE) on
.text segment remap and try to force thp backing if available but not
directly reclaim for non VM_HUGEPAGE vmas. This was very advantageous.
We prefer that to stay unchanged and allow kcompactd compaction to be
triggered in background by everybody else as opposed to direct reclaim.
We do not have that ability without this patch.
Without this patch, we will be forced to offer multiple sysfs tunables to
define (1) direct vs background compact, (2) madvise behavior, (3) always,
(4) never and we cannot have 2^4 settings for "defrag" alone.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>