On (12/19/16 09:12), Michal Hocko wrote: > On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote: > [...] > > as far as I can tell, now for_each_populated_zone() iterations are > > split by non-CONT printk() from show_zone_node(), which previously > > has been printk(KERN_CONT "%s: ", zone->name), so pr_cont(\n) > > between iterations was important, but now that non-CONT printk() > > should do the trick. it's _a bit_ hacky, though. > > Do you consider that more hacky than the original? well, slightly. merely because (to me) implicit always relies on internals, which can change; while explicit does not (ideally). simply because of that. but I don't have any problems with your patch. -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>