On Tue, Nov 29, 2016 at 10:55:29AM -0800, Laura Abbott wrote: > > + WARN(!__is_lm_address(x), > + "virt_to_phys used for non-linear address :%pK\n", (void *)x); Nit: s/ :/: / It might be worth adding %pS too; i.e. WARN(!__is_lm_address(x), "virt_to_phys used for non-linear address: %pK (%pS)\n", (void *)x, (void *)x); ... that way we might get a better idea before we have to resort to grepping objdump output. Other than that this looks good to me. This builds cleanly with and without DEBUG_VIRTUAL enabled, and boots happily with DEBUG_VIRTUAL disabled. With both DEBUG_VIRTUAL and KASAN, I'm hitting a sea of warnings from kasan_init at boot time, but I don't think that's a problem with this patch as such, so FWIW: Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx> Tested-by: Mark Rutland <mark.rutland@xxxxxxx> Thanks, Mark. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>