On 12/01/2016 03:36 AM, Andrey Ryabinin wrote: > On 11/29/2016 09:55 PM, Laura Abbott wrote: >> __pa_symbol is the correct API to find the physical address of symbols. >> Switch to it to allow for debugging APIs to work correctly. > > But __pa() is correct for symbols. I see how __pa_symbol() might be a little > faster than __pa(), but there is nothing wrong in using __pa() on symbols. > >> Other >> functions such as p*d_populate may call __pa internally. Ensure that the >> address passed is in the linear region by calling lm_alias. > > Why it should be linear mapping address? __pa() translates kernel image address just fine. > This lm_alias() only obfuscates source code. Generated code is probably worse too. > > This is part of adding CONFIG_DEBUG_VIRTUAL for arm64. We want to differentiate between __pa and __pa_symbol to enforce stronger virtual checks and have __pa only be for linear map addresses. Thanks, Laura -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>