On Thu 01-12-16 10:30:05, Wei Fang wrote: > On 2016/11/30 17:51, Jan Kara wrote: > > On Tue 29-11-16 09:58:31, Wei Fang wrote: > >> Hi, Jan, > >> > >> On 2016/11/28 18:07, Jan Kara wrote: > >>> Good catch but I don't like sprinkling checks like this into the writeback > >>> code and furthermore we don't want to call into writeback code when block > >>> device is in the process of being destroyed which is what would happen with > >>> your patch. That is a bug waiting to happen... > >> > >> Agreed. Need another way to fix this problem. I looked through the > >> writeback cgroup code in __filemap_fdatawrite_range(), found if we > >> turn on CONFIG_CGROUP_WRITEBACK, a new crash will happen. > > > > OK, can you test with attached patch please? Thanks! > > I've tested this patch with linux-next about 2 hours, and all goes well. > Without this patch, kernel crashes in minutes. Good. Thanks for testing! I'll send the patch for inclusion. hONZA -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>