On Fri, Nov 19, 2010 at 01:39:57AM +0100, David Sterba wrote: > Commit d33b9f45 introduces a check if a vma is a hugetlbfs one and > later in 5dc37642 is moved under #ifdef CONFIG_HUGETLB_PAGE but > a needless find_vma call is left behind and it's result not used > anywhere else in the function. > > The sideefect of caching vma for @addr inside walk->mm is neither > utilized in walk_page_range() nor in called functions. > > Signed-off-by: David Sterba <dsterba@xxxxxxx> > Cc: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> > Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx> > Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx> > Cc: David Rientjes <rientjes@xxxxxxxxxx> > Cc: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx> > Cc: Lee Schermerhorn <lee.schermerhorn@xxxxxx> > Cc: Matt Mackall <mpm@xxxxxxxxxxx> > Cc: Mel Gorman <mel@xxxxxxxxx> > Cc: Wu Fengguang <fengguang.wu@xxxxxxxxx> Well spotted. Acked-by: Mel Gorman <mel@xxxxxxxxx> -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>