On Fri, 18 Nov 2016, Jeremy Lefaure wrote:
> Compiling shmem.c with CONFIG_SHMEM and
> CONFIG_TRANSAPRENT_HUGE_PAGECACHE enabled raises warnings on two unused
> functions when CONFIG_TMPFS and CONFIG_SYSFS are both disabled:
>
> mm/shmem.c:390:20: warning: ‘shmem_format_huge’ defined but not used
> [-Wunused-function]
> static const char *shmem_format_huge(int huge)
> ^~~~~~~~~~~~~~~~~
> mm/shmem.c:373:12: warning: ‘shmem_parse_huge’ defined but not used
> [-Wunused-function]
> static int shmem_parse_huge(const char *str)
> ^~~~~~~~~~~~~~~~
>
> A conditional compilation on tmpfs or sysfs removes the warnings.
>
> Signed-off-by: Jeremy Lefaure <jeremy.lefaure@xxxxxxxxxxxx>
Acked-by: Hugh Dickins <hughd@xxxxxxxxxx>
Thank you!
> ---
> mm/shmem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 2c74186..99595d8 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -370,6 +370,7 @@ static bool shmem_confirm_swap(struct address_space *mapping,
>
> int shmem_huge __read_mostly;
>
> +#if defined(CONFIG_SYSFS) || defined(CONFIG_TMPFS)
> static int shmem_parse_huge(const char *str)
> {
> if (!strcmp(str, "never"))
> @@ -407,6 +408,7 @@ static const char *shmem_format_huge(int huge)
> return "bad_val";
> }
> }
> +#endif
>
> static unsigned long shmem_unused_huge_shrink(struct shmem_sb_info *sbinfo,
> struct shrink_control *sc, unsigned long nr_to_split)
> --
> 2.10.2