On Thu, Nov 18, 2010 at 3:49 AM, Mel Gorman <mel@xxxxxxxxx> wrote:
>> +
>> +static inline void compound_lock_irqsave(struct page *page,
>> + unsigned long *flagsp)
>> +{
>> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> + unsigned long flags;
>> + local_irq_save(flags);
>> + compound_lock(page);
>> + *flagsp = flags;
>> +#endif
>> +}
>> +
>
> The pattern for spinlock irqsave passes in unsigned long, not unsigned
> long *. It'd be nice if they matched.
Indeed. Just make the thing return the flags the way the normal
spin_lock_irqsave() function does.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href