Bug in page_cache_tree_delete?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kirill,

I've noticed that your commit 83929372f629 (filemap: prepare find and
delete operations for huge pages) added to page_cache_tree_delete():

	int i, nr = PageHuge(page) ? 1 : hpage_nr_pages(page);

Isn't the logic computing 'nr' inverted? I'd expect that if page is
!PageHuge, we want to delete just one page... OTOH I'm surprised this would
not blow up anywhere if it was really wrong so maybe I just miss something.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]