Re: [PATCH] arm/vdso: introduce vdso_mremap hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/07/2016 09:27 PM, Russell King - ARM Linux wrote:
On Tue, Nov 01, 2016 at 08:22:14PM +0300, Dmitry Safonov wrote:
diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
index 53cf86cf2d1a..d1001f87c2f6 100644
--- a/arch/arm/kernel/vdso.c
+++ b/arch/arm/kernel/vdso.c
@@ -54,8 +54,11 @@ static const struct vm_special_mapping vdso_data_mapping = {
 	.pages = &vdso_data_page,
 };

+static int vdso_mremap(const struct vm_special_mapping *sm,
+		struct vm_area_struct *new_vma);

I'd much rather avoid this forward declaration.  Is there any reason the
function body can't be here?


Well, I didn't want it to be in the middle of static file variables -
those looks nice at this moment just on top of the file.
No other than that.

--
             Dmitry

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]