On Wed, Nov 02, 2016 at 03:00:53PM -0600, Laura Abbott wrote:
>
> __pa_symbol is technically the marco that should be used for kernel
> symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL.
Nit: s/marco/macro/
I see there are some other uses of __pa() that look like they could/should be
__pa_symbol(), e.g. in mark_rodata_ro().
I guess strictly speaking those need to be updated to? Or is there a reason
that we should not?
Thanks,
Mark.
> Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx>
> ---
> arch/arm64/mm/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 212c4d1..3236eb0 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -209,8 +209,8 @@ void __init arm64_memblock_init(void)
> * linear mapping. Take care not to clip the kernel which may be
> * high in memory.
> */
> - memblock_remove(max_t(u64, memstart_addr + linear_region_size, __pa(_end)),
> - ULLONG_MAX);
> + memblock_remove(max_t(u64, memstart_addr + linear_region_size,
> + __pa_symbol(_end)), ULLONG_MAX);
> if (memstart_addr + linear_region_size < memblock_end_of_DRAM()) {
> /* ensure that memstart_addr remains sufficiently aligned */
> memstart_addr = round_up(memblock_end_of_DRAM() - linear_region_size,
> --
> 2.10.1
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>