On Wed, Oct 26, 2016 at 11:18:52AM -0700, Linus Torvalds wrote: > On Mon, Oct 24, 2016 at 11:47 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > > > How about this instead: given that we already mark the shadow entries > > exceptional, and the exceptional bit is part of the radix tree API, > > can we just introduce a node->exceptional counter for those entries > > and have the radix tree code assist us with that instead? It adds the > > counting for non-shadow exceptional entries as well (shmem swap slots, > > and DAX non-page entries), unfortunately, but this is way cleaner. It > > also makes mapping->nrexceptional and node->exceptional consistent in > > DAX (Jan, could you please double check the accounting there?) > > > > What do you think? Lightly tested patch below. > > This certainly looks way better to me. I didn't *test* it, but it > doesn't make me scratch my head the way your previous patch did. Awesome, thanks. I'll continue to beat on this for a while and then send it on to Andrew. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>