On Wed, 17 Nov 2010, Tejun Heo wrote: > > pcpu_get_vm_areas() only uses GFP_KERNEL allocations, so remove the gfp_t > > formal and use the mask internally. > > > > Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx> > > Patch itself looks okay to me but why do you want to drop the > argument? > A recent thread[*] shows a problem whereas gfp masks may be passed into the vmalloc interface that restrict reclaim behavior, yet the underlying pte allocator unconditionally uses GFP_KERNEL. This is a first-pass at an effort to remove all gfp_t formals from the vmalloc interface (and can be completed once gfs2, ntfs, and ceph have converted) and require them to use GFP_KERNEL. Luckily for the per-cpu allocator, this was trivial since that happens to be the only use case already. [*] http://marc.info/?t=128942209500002 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>