Re: [PATCH v2] z3fold: fix the potential encode bug in encod_handle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Zhong Jiang,

On Mon, Oct 17, 2016 at 3:58 AM, zhong jiang <zhongjiang@xxxxxxxxxx> wrote:
> Hi,  Vitaly
>
> About the following patch,  is it right?
>
> Thanks
> zhongjiang
> On 2016/10/13 12:02, zhongjiang wrote:
>> From: zhong jiang <zhongjiang@xxxxxxxxxx>
>>
>> At present, zhdr->first_num plus bud can exceed the BUDDY_MASK
>> in encode_handle, it will lead to the the caller handle_to_buddy
>> return the error value.
>>
>> The patch fix the issue by changing the BUDDY_MASK to PAGE_MASK,
>> it will be consistent with handle_to_z3fold_header. At the same time,
>> change the BUDDY_MASK to PAGE_MASK in handle_to_buddy is better.

are you seeing problems with the existing code? first_num should wrap around
BUDDY_MASK and this should be ok because it is way bigger than the number
of buddies.

~vitaly

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]