On Fri 14-10-16 14:31:47, Ross Zwisler wrote: > On Tue, Sep 27, 2016 at 06:08:09PM +0200, Jan Kara wrote: > > Use vm_fault structure to pass cow_page, page, and entry in and out of > > the function. That reduces number of __do_fault() arguments from 4 to 1. > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > In looking at this I realized that vmf->entry is actually unused, as is the > entry we used to return back via __do_fault(). I guess they must have been in > there because at one point they were needed for dax_unlock_mapping_entry()? > Anyway, looking ahead I see patch 10 removes vmf->entry altogether. :) Yes :). > Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> Thanks. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>