Let's CC Andrew - http://lkml.kernel.org/r/1476026219-7974-1-git-send-email-penguin-kernel@xxxxxxxxxxxxxxxxxxx On Mon 10-10-16 09:21:23, Michal Hocko wrote: > On Mon 10-10-16 00:16:59, Tetsuo Handa wrote: > > Commit 63f53dea0c9866e9 ("mm: warn about allocations which stall for > > too long") by error embedded "\n" in the format string, resulting in > > strange output. > > > > [ 722.876655] kworker/0:1: page alloction stalls for 160001ms, order:0 > > [ 722.876656] , mode:0x2400000(GFP_NOIO) > > [ 722.876657] CPU: 0 PID: 6966 Comm: kworker/0:1 Not tainted 4.8.0+ #69 > > Ups, thanks for catching that. > > > Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> > > Acked-by: Michal Hocko <mhocko@xxxxxxxx> > > > --- > > mm/page_alloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index ca423cc..828ee76 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -3653,7 +3653,7 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask) > > /* Make sure we know about allocations which stall for too long */ > > if (time_after(jiffies, alloc_start + stall_timeout)) { > > warn_alloc(gfp_mask, > > - "page alloction stalls for %ums, order:%u\n", > > + "page alloction stalls for %ums, order:%u", > > jiffies_to_msecs(jiffies-alloc_start), order); > > stall_timeout += 10 * HZ; > > } > > -- > > 1.8.3.1 > > > > -- > Michal Hocko > SUSE Labs -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>