On Mon, Oct 03, 2016 at 09:59:02AM +0200, Jan Kara wrote: > IMO ->fault and ->pmd_fault can be merged, ->page_mkwrite and ->pfn_mkwrite > can be merged. There were even patches flying around for that. I want to do > that but it's not a priority now as the patch set it already large enough. > > I'm not sure whether merging ->fault and ->page_mkwrite would be really > helpful and it would certainly require some non-trivial changes in the > fault path. For example currently a write fault of a file mapping will > result in first ->fault being called which handles the read part of the > fault and then ->page_mkwrite is called to handle write-enabling of the > PTE. When the handlers would be merged, calling one handler twice would be > really strange. Except for the DAX path, where we apparently need to call out to the mkwrite handler from ->fault. Or at least used to, with some leftovers in XFS and not extN. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>