On 2016/9/29 7:55, Mike Kravetz wrote: > On 09/27/2016 12:23 PM, Mike Kravetz wrote: >> On 09/27/2016 07:16 AM, zhongjiang wrote: >>> From: zhong jiang <zhongjiang@xxxxxxxxxx> >>> >>> when the huge page is added to the page cahce (huge_add_to_page_cache), >>> the page private flag will be cleared. since this code >>> (remove_inode_hugepages) will only be called for pages in the >>> page cahce, PagePrivate(page) will always be false. >>> >>> The patch remove the code without any functional change. >>> >>> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> >>> --- >>> fs/hugetlbfs/inode.c | 11 +++++------ >>> include/linux/hugetlb.h | 2 +- >>> mm/hugetlb.c | 4 ++-- >>> 3 files changed, 8 insertions(+), 9 deletions(-) >>> >>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >>> index 4ea71eb..40d0afe 100644 >>> --- a/fs/hugetlbfs/inode.c >>> +++ b/fs/hugetlbfs/inode.c >>> @@ -458,18 +458,17 @@ static void remove_inode_hugepages(struct inode *inode, loff_t lstart, >>> * cache (remove_huge_page) BEFORE removing the >>> * region/reserve map (hugetlb_unreserve_pages). In >>> * rare out of memory conditions, removal of the >>> - * region/reserve map could fail. Before free'ing >>> - * the page, note PagePrivate which is used in case >>> - * of error. >>> + * region/reserve map could fail. Correspondingly, >>> + * the subpool and global reserve usage count can need >>> + * to be adjusted. >>> */ >>> - rsv_on_error = !PagePrivate(page); > You also need to remove the definition of rsv_on_error. > > Sorry, I missed that on the review. Thanks, I will remove it now. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>