Re: page_waitqueue() considered harmful

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 26, 2016 at 05:23:29PM -0400, Rik van Riel wrote:
> On Mon, 2016-09-26 at 13:58 -0700, Linus Torvalds wrote:
> 
> > Is there really any reason for that incredible indirection? Do we
> > really want to make the page_waitqueue() be a per-zone thing at all?
> > Especially since all those wait-queues won't even be *used* unless
> > there is actual IO going on and people are really getting into
> > contention on the page lock.. Why isn't the page_waitqueue() just one
> > statically sized array?
> 
> Why are we touching file pages at all during fork()?

We are not.
Unless the vma has private pages (vma->anon_vma is not NULL).

See first lines for copy_page_range().

We probably can go futher and skip non-private pages within file VMA.
But we would need to touch struct page in this case, so it doesn't make
sense.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]