On 09/12/2016 11:18 AM, Michal Hocko wrote:
On Mon 05-09-16 16:18:29, Vlastimil Babka wrote:
Also OOM is skipped for __GFP_THISNODE
allocations, so we might also consider the same for nodemask-constrained
allocations?
> The patch checks whether it is the last node on the system, and if it is, then
> don't clear the nid in the nodemask.
I'd rather see the allocation not OOM, and rely on the fallback in
new_node_page() that doesn't have nodemask. But I suspect it might also make
sense to treat empty nodemask as something unexpected and put some WARN_ON
(instead of OOM) in the allocator.
To be honest I am really not all that happy about 394e31d2ceb4
("mem-hotplug: alloc new page from a nearest neighbor node when
mem-offline") and find it a bit fishy. I would rather re-iterate that
patch rather than build new hacks on top.
OK, IIRC I suggested the main idea of clearing the current node from nodemask
and relying on nodelist to get us the other nodes sorted by their distance.
Which I thought was an easy way to get to the theoretically optimal result. How
would you rewrite it then? (but note that the fix is already mainline).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>