On Mon, 12 Sep 2016, Anshuman Khandual wrote: > >> > after memory or node hot[un]plug is desirable. This change adds one > >> > new sysfs interface (/sys/devices/system/memory/system_zone_details) > >> > which will fetch and dump this information. > > Doesn't this violate the "one value per file" sysfs rule? Does it > > belong in debugfs instead? > > Yeah sure. Will make it a debugfs interface. > So the intended reader of this file is running as root? > > I also really question the need to dump kernel addresses out, filtered > > or not. What's the point? > > Hmm, thought it to be an additional information. But yes its additional > and can be dropped. > I'm questioning if this information can be inferred from information already in /proc/zoneinfo and sysfs. We know the no-fallback zonelist is going to include the local node, and we know the other zonelists are either node ordered or zone ordered (or do we need to extend vm.numa_zonelist_order for default?). I may have missed what new knowledge this interface is imparting on us. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>