> On Thu, Nov 11, 2010 at 07:07:04PM +0000, Mel Gorman wrote: > > + if (COMPACTION_BUILD) > > + sc->lumpy_reclaim_mode = LUMPY_MODE_COMPACTION; > > + else > > + sc->lumpy_reclaim_mode = LUMPY_MODE_CONTIGRECLAIM; > > > > Gack, I posted the slightly wrong version. This version prevents lumpy > reclaim ever being used. The figures I posted were for a patch where > this condition looked like > > if (COMPACTION_BUILD && priority > DEF_PRIORITY - 2) > sc->lumpy_reclaim_mode = LUMPY_MODE_COMPACTION; > else > sc->lumpy_reclaim_mode = LUMPY_MODE_CONTIGRECLAIM; Can you please tell us your opinition which is better 1) automatically turn lumby on by priority (this approach) 2) introduce GFP_LUMPY (andrea proposed). I'm not sure which is better, then I'd like to hear both pros/cons concern. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>