On 2016/9/5 10:59, Li Zhong wrote: > Commit 394e31d2c introduced new_node_page() for memory hotplug. > > In new_node_page(), the nid is cleared before calling __alloc_pages_nodemask(). > But if it is the only node of the system, and the first round allocation fails, > it will not be able to get memory from an empty nodemask, and trigger oom. > Hi, Yes, I missed this case, thanks for your fix. Thanks, Xishi Qiu > The patch checks whether it is the last node on the system, and if it is, then > don't clear the nid in the nodemask. > > Reported-by: John Allen <jallen@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Li Zhong <zhong@xxxxxxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>