On Sat, Aug 27, 2016 at 05:14:34PM +0300, Konstantin Khlebnikov wrote: > Tags should be set only for last index of THP range: this way iterator > will find them regardless of starting index. I don't think this works well for DAX. We really want to to have the tags be consistent for all indices within a multi-order range. Meaning, if I fault in an order-9 fault, and then I get a PTE write fault to anywhere within that range, I want to be able to do a lookup, find the one canonical entry that has my dirty tags, flush, and eventually I want to be able to clear that one tag. I agree that it's *possible* to do all of this with your code, but it puts a lot of onus on the user. I now have to have two paths, one for order-0 entries, and one for multi-order entries where I know to use a specific entry as my canonical entry where I can count on the log bit, on tags, etc. This was actually the way that it was done with the old PMD code. We used the first aligned index for the PMD to be the one source of truth. On every fault I would first check to see if there was a PMD aligned entry, and then if not I would treat it like a normal 4k fault. The multi-order radix tree with sibling entries was a huge step forward. I guess my question is the same as Matthew's: what is the problem you need to solve with this code, and why can't the current code be made to solve it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>