Re: [PATCH v3] fix __set_page_dirty_no_writeback() return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 10 Nov 2010, David Rientjes wrote:

> > diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> > index bf85062..1ebfb86 100644
> > --- a/mm/page-writeback.c
> > +++ b/mm/page-writeback.c
> > @@ -1158,7 +1158,7 @@ EXPORT_SYMBOL(write_one_page);
> >  int __set_page_dirty_no_writeback(struct page *page)
> >  {
> >  	if (!PageDirty(page))
> > -		SetPageDirty(page);
> > +		return !TestSetPageDirty(page);
> >  	return 0;
> >  }
> 
> No need for a conditional, just return !TestSetPageDirty(page).
> 

Oops, just read Andrew's reply to v1 of the patch about the cacheline 
invalidation of bts, sorry for the noise.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]