On 08/17/2016 03:02 AM, Jan Kara wrote:
> On Tue 16-08-16 17:00:43, Bart Van Assche wrote:
>> If a fatal signal has been received, fail immediately instead of
>> trying to read more data.
>>
>> See also commit ebded02788b5 ("mm: filemap: avoid unnecessary
>> calls to lock_page when waiting for IO to complete during a read")
>
> The patch looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> BTW: Did you see some real world impact of the change? If yes, it would be
> good to describe in the changelog.
Hello Jan,
Thanks for the review.
This patch has an impact on my tests. However, I do not yet have a full
root-cause analysis for what I observed in my tests. That is why I
hadn't mentioned any further details in the patch description.
While running fio on top of a filesystem (ext4 or xfs), dm-mpath and
the ib_srp driver I noticed that removing and restoring paths triggered
several types of hangs. The call trace of one of these hangs, the one
that made me look at do_generic_file_read(), can be found below. I'm
currently testing a block layer patch to see whether it resolves this
hang.
Bart.
kpartx D ffff8800409d3be8 0 16392 16355 0x00000000
Call Trace:
[<ffffffff8161f577>] schedule+0x37/0x90
[<ffffffff81623bcf>] schedule_timeout+0x27f/0x470
[<ffffffff8161e94f>] io_schedule_timeout+0x9f/0x110
[<ffffffff8161fd16>] bit_wait_io+0x16/0x60
[<ffffffff8161f9a6>] __wait_on_bit+0x56/0x80
[<ffffffff81152e2d>] wait_on_page_bit_killable+0xbd/0xc0
[<ffffffff81152f60>] generic_file_read_iter+0x130/0x770
[<ffffffff812134b0>] blkdev_read_iter+0x30/0x40
[<ffffffff811d267b>] __vfs_read+0xbb/0x130
[<ffffffff811d2a61>] vfs_read+0x91/0x130
[<ffffffff811d3de4>] SyS_read+0x44/0xa0
[<ffffffff81624fa5>] entry_SYSCALL_64_fastpath+0x18/0xa8
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>