__set_page_dirty_no_writeback() should return true if it actually transitioned the page from a clean to dirty state although it seems nobody used its return value now. Signed-off-by: Bob Liu <lliubbo@xxxxxxxxx> --- mm/page-writeback.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index bf85062..e8f5f06 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1157,9 +1157,7 @@ EXPORT_SYMBOL(write_one_page); */ int __set_page_dirty_no_writeback(struct page *page) { - if (!PageDirty(page)) - SetPageDirty(page); - return 0; + return !TestSetPageDirty(page); } /* -- 1.6.3.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>