On Mon 01-08-16 16:26:26, Vladimir Davydov wrote: [...] > static struct mem_cgroup *mem_cgroup_id_get_active(struct mem_cgroup *memcg) > { > - while (!atomic_inc_not_zero(&memcg->id.ref)) > + while (!atomic_inc_not_zero(&memcg->id.ref)) { > + VM_BUG_ON(mem_cgroup_is_root(memcg)); > memcg = parent_mem_cgroup(memcg); > + } why is this BUG_ON ok? What if the root.use_hierarchy=true? > return memcg; > } -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>