On Tue, Nov 09, 2010 at 05:24:31PM +0800, Greg Thelen wrote: > mem_cgroup_page_stat() used to return a negative page count > value to indicate value. > > mem_cgroup_page_stat() has changed so it never returns > error so convert the return value to the traditional page > count type (unsigned long). > > Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx> > --- > + /* > + * The sum of unlocked per-cpu counters may yield a slightly negative > + * value. This function returns an unsigned value, so round it up to > + * zero to avoid returning a very large value. > + */ > + if (value < 0) > + value = 0; nitpick: it's good candidate for unlikely(). Reviewed-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> Sorry, I lose track to the source code after so many patches. It would help if you can put the patches to a git tree. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>