On 07/26/2016 06:39 PM, hejianet wrote: >>> >> and you choose to patch both of the alloc_*() functions. Why not just >> fix it at the common call site? Seems like that >> spin_lock(&hugetlb_lock) could be a cond_resched_lock() which would fix >> both cases. > I agree to move the cond_resched() to a common site in > set_max_huge_pages(). But do you mean the spin_lock in this while > loop can be replaced by cond_resched_lock? IIUC, cond_resched_lock = > spin_unlock+cond_resched+spin_lock. So could you please explain more > details about it? Thanks. Ahh, good point. A plain cond_resched() outside the lock is probably sufficient here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>