On Mon, Jul 25, 2016 at 07:34:12AM +0000, zijun_hu@xxxxxxx wrote: > Hi All, > There is a bug in mm/memblock.c > Could you review and phase-in this patch? > Thanks a lot > > From 3abf1822d30f77f126bd7a3c09bb243d9c17a029 Mon Sep 17 00:00:00 2001 > From: zijun_hu <zijun_hu@xxxxxxx> > Date: Mon, 25 Jul 2016 15:06:57 +0800 > Subject: [PATCH] mm/memblock.c: fix index adjustment error in > __next_mem_range_rev() > > fix region index adjustment error when parameter type_b of > __next_mem_range_rev() == NULL > > Signed-off-by: zijun_hu <zijun_hu@xxxxxxx> > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index ac12489..b14973e 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1024,7 +1024,7 @@ void __init_memblock __next_mem_range_rev(u64 *idx, int nid, ulong flags, > *out_end = m_end; > if (out_nid) > *out_nid = m_nid; > - idx_a++; > + idx_a--; Looks good to me. Do you happen to have a test case for this bug? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>