On 07/15, Topi Miettinen wrote: > > On 07/15/16 15:14, Oleg Nesterov wrote: > > > > Btw this is not right. The same for the previous patch which tracks > > RLIMIT_STACK. The "current" task can debugger/etc. > > acct_stack_growth() is called from expand_upwards() and > expand_downwards(). They call security_mmap_addr() and the various LSM > implementations also use current task in the checks. Are these also not > right? Just suppose that the stack grows because you read/write to /proc/pid/mem. > > Yes, yes, this just reminds that the whole rlimit logic in this path > > is broken but still... > > I'd be happy to fix the logic with a separate prerequisite patch and > then use the right logic for this patch, but I'm not sure I know how. > Could you elaborate a bit? If only I Knew how to fix this ;) I mean, if only I could suggest a simple fix. Because IMHO we do not really care, rlimts are obsolete. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>