On Fri, Jul 15, 2016 at 02:09:24PM +0100, Mel Gorman wrote: > From: Minchan Kim <minchan@xxxxxxxxxx> > > The node_pages_scanned represents the number of scanned pages > of node for reclaim so it's pointless to show it as kilobytes. > > As well, node_pages_scanned is per-node value, not per-zone. > > This patch changes node_pages_scanned per-zone-killobytes > with per-node-count. > > Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> > Signed-off-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> > --- > mm/page_alloc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index f80a0e57dcc8..7edd311a63f1 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4345,6 +4345,7 @@ void show_free_areas(unsigned int filter) > #endif > " writeback_tmp:%lukB" > " unstable:%lukB" > + " pages_scanned:%lu" > " all_unreclaimable? %s" > "\n", > pgdat->node_id, > @@ -4367,6 +4368,7 @@ void show_free_areas(unsigned int filter) > K(node_page_state(pgdat, NR_SHMEM)), > K(node_page_state(pgdat, NR_WRITEBACK_TEMP)), > K(node_page_state(pgdat, NR_UNSTABLE_NFS)), > + node_page_state(zone->zone_pgdat, NR_PAGES_SCANNED), Oops, It should be pgdat, not zone->zone_pgdat. Andrew, please fold it. >From 0b058f64335764b82439a3c24fad8573cc1474d7 Mon Sep 17 00:00:00 2001 From: Minchan Kim <minchan@xxxxxxxxxx> Date: Sat, 16 Jul 2016 19:07:51 +0900 Subject: [PATCH] mm: fix node_pages_scanned Use pgdat for node stat instead of zone->pgdat. Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7edd311..7547b6b 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4368,7 +4368,7 @@ void show_free_areas(unsigned int filter) K(node_page_state(pgdat, NR_SHMEM)), K(node_page_state(pgdat, NR_WRITEBACK_TEMP)), K(node_page_state(pgdat, NR_UNSTABLE_NFS)), - node_page_state(zone->zone_pgdat, NR_PAGES_SCANNED), + node_page_state(pgdat, NR_PAGES_SCANNED), !pgdat_reclaimable(pgdat) ? "yes" : "no"); } -- 1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>