On Mon, Nov 08, 2010 at 09:01:54AM +0900, Minchan Kim wrote: > On Mon, Nov 8, 2010 at 7:14 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > The statistic counters are in units of pages, there is no reason to > > make them 64-bit wide on 32-bit machines. > > > > Make them native words. Since they are signed, this leaves 31 bit on > > 32-bit machines, which can represent roughly 8TB assuming a page size > > of 4k. > > > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > This patch changes mem_cgroup_recursive_idx_stat with > mem_cgroup_recursive_stat as well. > As you know, It would be better to be another patch although it's > trivial. But I don't mind it. > I like the name. :) I also feel that it's not too nice to mix such cleanups with functionality changes. But I found the name too appalling to leave it alone, and a separate patch not worth the trouble. If somebody has strong feelings, I will happily split it up. Thanks for your review, Minchan. Hannes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>