On Fri 08-07-16 01:10:02, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > On Sun 03-07-16 11:40:41, Tetsuo Handa wrote:
> > > >From 00b7a14653c9700429f89e4512f6000a39cce59d Mon Sep 17 00:00:00 2001
> > > From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> > > Date: Sat, 2 Jul 2016 23:03:03 +0900
> > > Subject: [PATCH 6/8] mm,oom_reaper: Stop clearing TIF_MEMDIE on remote thread.
> > >
> > > Since oom_has_pending_mm() controls whether to select next OOM victim,
> > > we no longer need to clear TIF_MEMDIE on remote thread. Therefore,
> > > revert related changes in commit 36324a990cf578b5 ("oom: clear TIF_MEMDIE
> > > after oom_reaper managed to unmap the address space") and
> > > commit e26796066fdf929c ("oom: make oom_reaper freezable") and
> > > commit 74070542099c66d8 ("oom, suspend: fix oom_reaper vs.
> > > oom_killer_disable race").
> >
> > The last revert is not safe. See
> > http://lkml.kernel.org/r/1467365190-24640-3-git-send-email-mhocko@xxxxxxxxxx
>
> Why?
Because there is no guarantee of calling exit_oom_victim and thus
oom_disable making a forward progress. The changelog referenced above
tries to explain that.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>