Tetsuo, I'll try to actually read this series later, although I will leave the actual review to maintainers anyway... Just a couple of questions for now, On 07/03, Tetsuo Handa wrote: > > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -722,6 +722,7 @@ static inline void __mmput(struct mm_struct *mm) > } > if (mm->binfmt) > module_put(mm->binfmt->module); > + exit_oom_mm(mm); Is it strictly necessary? At first glance not. Sooner or later oom_reaper() should find this mm_struct and do exit_oom_mm(). And given that mm->mm_users is already 0 the "extra" __oom_reap_vmas() doesn't really hurt. It would be nice to remove exit_oom_mm() from __mmput(); it takes the global spinlock for the very unlikely case, and if we can avoid it here then perhaps we can remove ->oom_mm from mm_struct. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>