On Jul 1, 2016 9:47 AM, "Borislav Petkov" <bp@xxxxxxxxx> wrote: > > On Fri, Jul 01, 2016 at 09:30:37AM -0700, Andy Lutomirski wrote: > > I put the ifdef there to prevent anyone from accidentally using it in > > a 64-bit code path, not to save a bit. We could put in the middle of > > the list to make the mistake much less likely to be repeated, I > > suppose. > > Well, if someone does, someone will notice pretty soon, no? Dunno. ESPFIX was broken under KVM for years and no one notices. > > I just don't see the reason to worry but maybe I'm missing it. > > And we can call it X86_BUG_ESPFIX_X86_32 or so too... We could do that, too, I guess. But the current solution is only two extra lines of code. We could reorder the things so that it's in the middle instead of at the end, I suppose. --Andy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>