On Wed, 15 Jun 2016 14:16:20 +0530 Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> wrote: > On 06/15/2016 12:22 PM, Ganesh Mahendran wrote: > > The caller __alloc_pages_direct_compact() already check (order == 0). > > So no need to check again. > > Yeah, the caller (__alloc_pages_direct_compact) checks if the order of > allocation is 0. But we can remove it there and keep it in here as this > is the actual entry point for direct page compaction. I think the check in __alloc_pages_direct_compact() is OK - it's a bit silly to do a (small) bunch of additional work in __alloc_pages_direct_compact() when orer==0. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>