On Wed, Jun 08, 2016 at 04:39:44PM +0900, Minchan Kim wrote:
> On Mon, Jun 06, 2016 at 03:48:31PM -0400, Johannes Weiner wrote:
> > @@ -832,9 +854,9 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
> > * Add the passed pages to the LRU, then drop the caller's refcount
> > * on them. Reinitialises the caller's pagevec.
> > */
> > -void __pagevec_lru_add(struct pagevec *pvec)
> > +void __pagevec_lru_add(struct pagevec *pvec, bool new)
> > {
> > - pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
> > + pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, (void *)new);
> > }
>
> Just trivial:
>
> 'new' argument would be not clear in this context what does it mean
> so worth to comment it, IMO but no strong opinion.
True, it's a little mysterious. I'll document it.
> Other than that,
>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>