Re: [PATCH] mm: memcontrol: remove BUG_ON in uncharge_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 08, 2016 at 09:25:54AM +0200, Michal Hocko wrote:
> On Wed 08-06-16 15:00:48, roy.qing.li@xxxxxxxxx wrote:
> > From: Li RongQing <roy.qing.li@xxxxxxxxx>
> > 
> > when call uncharge_list, if a page is transparent huge, and not need to
> > BUG_ON about non-transparent huge, since nobody should be be seeing the
> > page at this stage and this page cannot be raced with a THP split up
> 
> Johannes do you remember why you have kept this bug on even after
> 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API")?

No, I just copied it over without thinking too much about it. That
patch was pretty drastic, so why not keep the sanity checks in case
one of the many assumptions it made were flawed...

But it's probably okay to drop it at this point.

> > Signed-off-by: Li RongQing <roy.qing.li@xxxxxxxxx>

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]