On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote: > Since the LRUs were split into anon and file lists, the VM has been > balancing between page cache and anonymous pages based on per-list > ratios of scanned vs. rotated pages. In most cases that tips page > reclaim towards the list that is easier to reclaim and has the fewest > actively used pages, but there are a few problems with it: > > 1. Refaults and in-memory rotations are weighted the same way, even > though one costs IO and the other costs CPU. When the balance is > off, the page cache can be thrashing while anonymous pages are aged > comparably slower and thus have more time to get even their coldest > pages referenced. The VM would consider this a fair equilibrium. > > 2. The page cache has usually a share of use-once pages that will > further dilute its scanned/rotated ratio in the above-mentioned > scenario. This can cease scanning of the anonymous list almost > entirely - again while the page cache is thrashing and IO-bound. > > Historically, swap has been an emergency overflow for high memory > pressure, and we avoided using it as long as new page allocations > could be served from recycling page cache. However, when recycling > page cache incurs a higher cost in IO than swapping out a few unused > anonymous pages would, it makes sense to increase swap pressure. > > In order to accomplish this, we can extend the thrash detection code > that currently detects workingset changes within the page cache: when > inactive cache pages are thrashing, the VM raises LRU pressure on the > otherwise protected active file list to increase competition. However, > when active pages begin refaulting as well, it means that the page > cache is thrashing as a whole and the LRU balance should tip toward > anonymous. This is what this patch implements. > > To tell inactive from active refaults, a page flag is introduced that > marks pages that have been on the active list in their lifetime. This > flag is remembered in the shadow page entry on reclaim, and restored > when the page refaults. It is also set on anonymous pages during > swapin. When a page with that flag set is added to the LRU, the LRU > balance is adjusted for the IO cost of reclaiming the thrashing list. Johannes, It seems like you are saying that the shadow entry is also present for anonymous pages that are swapped out. But once a page is swapped out, its entry is removed from the radix tree and we won't be able to store the shadow page entry as for file mapped page in __remove_mapping. Or are you thinking of modifying the current code to keep the radix tree entry? I may be missing something so will appreciate if you can clarify. Thanks. Tim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>