On (05/19/16 11:18), Dan Streetman wrote:
[..]
> zs_stat_root = debugfs_create_dir("zsmalloc", NULL);
> if (!zs_stat_root)
> - return -ENOMEM;
> -
> - return 0;
> + pr_warn("debugfs 'zsmalloc' stat dir creation failed\n");
> }
>
> static void __exit zs_stat_exit(void)
> @@ -573,17 +575,19 @@ static const struct file_operations zs_stat_size_ops = {
> .release = single_release,
> };
>
> -static int zs_pool_stat_create(struct zs_pool *pool, const char *name)
> +static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
> {
> struct dentry *entry;
>
> - if (!zs_stat_root)
> - return -ENODEV;
> + if (!zs_stat_root) {
> + pr_warn("no root stat dir, not creating <%s> stat dir\n", name);
> + return;
> + }
just a small nit, there are basically two warn messages now for
`!zs_stat_root':
debugfs 'zsmalloc' stat dir creation failed
no root stat dir, not creating <%s> stat dir
may be we need only one of them; but no strong opinions.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>