On Thu 19-05-16 15:57:18, roy.qing.li@xxxxxxxxx wrote:
> From: Li RongQing <roy.qing.li@xxxxxxxxx>
>
> move the comments for get_mctgt_type before the get_mctgt_type function
heh, it used to be much closer back then when introduced but we have
grown quite some code since then...
> Signed-off-by: Li RongQing <roy.qing.li@xxxxxxxxx>
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> ---
> mm/memcontrol.c | 37 +++++++++++++++++++------------------
> 1 file changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index fe787f5..00981d2 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4290,24 +4290,6 @@ static int mem_cgroup_do_precharge(unsigned long count)
> return 0;
> }
>
> -/**
> - * get_mctgt_type - get target type of moving charge
> - * @vma: the vma the pte to be checked belongs
> - * @addr: the address corresponding to the pte to be checked
> - * @ptent: the pte to be checked
> - * @target: the pointer the target page or swap ent will be stored(can be NULL)
> - *
> - * Returns
> - * 0(MC_TARGET_NONE): if the pte is not a target for move charge.
> - * 1(MC_TARGET_PAGE): if the page corresponding to this pte is a target for
> - * move charge. if @target is not NULL, the page is stored in target->page
> - * with extra refcnt got(Callers should handle it).
> - * 2(MC_TARGET_SWAP): if the swap entry corresponding to this pte is a
> - * target for charge migration. if @target is not NULL, the entry is stored
> - * in target->ent.
> - *
> - * Called with pte lock held.
> - */
> union mc_target {
> struct page *page;
> swp_entry_t ent;
> @@ -4496,6 +4478,25 @@ out:
> return ret;
> }
>
> +/**
> + * get_mctgt_type - get target type of moving charge
> + * @vma: the vma the pte to be checked belongs
> + * @addr: the address corresponding to the pte to be checked
> + * @ptent: the pte to be checked
> + * @target: the pointer the target page or swap ent will be stored(can be NULL)
> + *
> + * Returns
> + * 0(MC_TARGET_NONE): if the pte is not a target for move charge.
> + * 1(MC_TARGET_PAGE): if the page corresponding to this pte is a target for
> + * move charge. if @target is not NULL, the page is stored in target->page
> + * with extra refcnt got(Callers should handle it).
> + * 2(MC_TARGET_SWAP): if the swap entry corresponding to this pte is a
> + * target for charge migration. if @target is not NULL, the entry is stored
> + * in target->ent.
> + *
> + * Called with pte lock held.
> + */
> +
> static enum mc_target_type get_mctgt_type(struct vm_area_struct *vma,
> unsigned long addr, pte_t ptent, union mc_target *target)
> {
> --
> 2.1.4
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>