On 05/17, Michal Hocko wrote: > > On Mon 16-05-16 19:22:54, Oleg Nesterov wrote: > > > The patch adds the new trivial helper, mmget_not_zero(), it can have more users. > > Is this really helpful? Well, this is subjective of course, but I think the code looks a bit better this way. uprobes, fs/proc and more can use this helper too. And in fact the initial version of this patch did atomic_inc_not_zero(mm->users) by hand, then it was suggested to add a helper. > > Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> > > The patch seems good to me but I am not familiar with the userfaultfd > internals enought to give you reviewed-by nor acked-by. I welcome the > change anyway. Thanks ;) Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>