On Mon, 16 May 2016, Michal Hocko wrote: > I agree with Christoph that vmstat_refresh is PROC_FS only so we should > fix it there. It is not like this would be generally reusable helper... > Why don't we just do: Looks good. Acked-by: Christoph Lameter <cl@xxxxxxxxx> > --- > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 57a24e919907..c759b526287b 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1370,6 +1370,7 @@ static void refresh_vm_stats(struct work_struct *work) > refresh_cpu_vm_stats(true); > } > > +#ifdef CONFIG_PROC_FS > int vmstat_refresh(struct ctl_table *table, int write, > void __user *buffer, size_t *lenp, loff_t *ppos) > { > @@ -1422,6 +1423,7 @@ int vmstat_refresh(struct ctl_table *table, int write, > *lenp = 0; > return 0; > } > +#endif > > static void vmstat_update(struct work_struct *w) > { > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>