On Mon 16-05-16 11:27:56, Vlastimil Babka wrote: > On 05/16/2016 10:14 AM, Michal Hocko wrote: > > On Mon 16-05-16 09:31:44, Vlastimil Babka wrote: [...] > > > Also my understanding of the initial compaction priorities is to lower the > > > latency if fragmentation is just light and there's enough memory. Once we > > > start struggling, I don't see much point in not switching to the full > > > compaction priority quickly. > > > > That is true but why to compact when there are high order pages and they > > are just hidden by the watermark check. > > Compaction should skip such zone regardless of priority. The point I've tried to raise is that we shouldn't conflate the purpose of the two. The reclaim is here primarily to get us over the watermarks while compaction is here to form high order pages. If we get both together the distinction is blured which, I believe, will lead to more complicated code in the end. I might be wrong here of course but let's try to have compaction as much wmark check free as possible. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>