On Tue 10-05-16 17:00:08, Joonsoo Kim wrote: > 2016-05-10 16:09 GMT+09:00 Vlastimil Babka <vbabka@xxxxxxx>: > > On 05/10/2016 08:41 AM, Joonsoo Kim wrote: > >> > >> You applied band-aid for CONFIG_COMPACTION and fixed some reported > >> problem but it is also fragile. Assume almost pageblock's skipbit are > >> set. In this case, compaction easily returns COMPACT_COMPLETE and your > >> logic will stop retry. Compaction isn't designed to report accurate > >> fragmentation state of the system so depending on it's return value > >> for OOM is fragile. > > > > > > Guess I'll just post a RFC now, even though it's not much tested... > > I will look at it later. But, I'd like to say something first. > Even if compaction returns more accurate fragmentation states, it's not a good > idea to depend on compaction's result to decide OOM. We have reclaimable but > not migratable pages. Depending on compaction's result cannot deal > with this case. > > For example, please assume that all of the system memory are filled > with THP pages > or reclaimable slab pages. They cannot be migrated but we can reclaim them. Direct reclaim should break those THP pages or shrink those slabs. And we make sure to reclaim before we consider final call for fail from compaction feedback. If this is a vast majority of memory we should hit it pretty reliably AFAICS. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>