On (04/28/16 15:07), Andrew Morton wrote: > Needed a bit of tweaking due to > http://ozlabs.org/~akpm/mmotm/broken-out/zsmalloc-reordering-function-parameter.patch Thanks. > From: Dan Streetman <ddstreet@xxxxxxxx> > Subject: mm/zsmalloc: don't fail if can't create debugfs info > > Change the return type of zs_pool_stat_create() to void, and > remove the logic to abort pool creation if the stat debugfs > dir/file could not be created. > > The debugfs stat file is for debugging/information only, and doesn't > affect operation of zsmalloc; there is no reason to abort creating > the pool if the stat file can't be created. This was seen with > zswap, which used the same name for all pool creations, which caused > zsmalloc to fail to create a second pool for zswap if > CONFIG_ZSMALLOC_STAT was enabled. no real objections from me. given that both zram and zswap now provide unique names for zsmalloc stats dir, this patch does not fix any "real" (observed) problem /* ENOMEM in debugfs_create_dir() is a different case */. so it's more of a cosmetic patch. FWIW, Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>