On Fri, Oct 22, 2010 at 10:27:55AM -0500, Christoph Lameter wrote: > On Fri, 22 Oct 2010, Mel Gorman wrote: > > > > > +void disable_pgdat_percpu_threshold(pg_data_t *pgdat) > > Call this set_pgdat_stat_threshold() and make it take a calculate_pressure > () function? > > void set_pgdat_stat_threshold(pg_data_t *pgdat, int (*calculate_pressure)(struct zone *)) ? > > Then do > > set_pgdat_stat_threshold(pgdat, threshold_normal) > > set_pgdat_stat_threshold(pgdat, threshold_pressure) > > ? > I considered it but thought the indirection would look tortured and hinder review. If we agree on the basic premise, I would do it as two patches. Would that suit? -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>